Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Automatic Display Answer global setting #17464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Automatic Display Answer global setting #17464

wants to merge 1 commit into from
+8 −32

Conversation

MorenoTropical
Copy link
Contributor

People get confused when they enable Auto Advance but it doesn't work. The preference had an use when Anki didn't have Auto advance, but now it doesn't have a purpose because everything can be configured from deck options

Example: https://forums.ankiweb.net/t/auto-advance-in-deck-options/51898

Fixes

Approach

Removed the global setting

How Has This Been Tested?

Tested if auto advance still works

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions GitHub Actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@MorenoTropical MorenoTropical force-pushed the autodisplay branch 3 times, most recently from 4f81ac5 to fb94679 Compare November 19, 2024 15:43
@MorenoTropical
Remove Automatic Display Answer global setting
fb94679 
People get confused when they enable Auto Advance but it doesn't work. The preference had an use when Anki didn't have Auto advance, but now it doesn't have a purpose.

Example: https://forums.ankiweb.net/t/auto-advance-in-deck-options/51898
@brishtibheja
Copy link

I appreciate this as this has confused many users before (including me). But perhaps, some people find use in this if they use Auto Advance in desktop but not on their phones? The desktop also has an option for turning on auto advance other than the deck options one.

@MorenoTropical
Copy link
Contributor Author

The desktop also has an option for turning on auto advance other than the deck options one.

It doesn't.

@brishtibheja
Copy link

brishtibheja commented Nov 19, 2024 •
edited
Loading

I thought you needed to select Auto Advance as documented here: https://docs.ankiweb.net/deck-options.html#auto-advance

We updated that topic a few months ago, so shouldn't get outdated. But I could be wrong about desktop.

@MorenoTropical
Copy link
Contributor Author

MorenoTropical commented Nov 20, 2024 •
edited
Loading

I thought you needed to select Auto Advance

That isn't a setting. It's equivalent to the Toggle auto advance feature in AnkiDroid's reviewer. Haven't you checked it before stating it?

There isn't a global setting.

BrayanDSO
BrayanDSO approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ecossystem compatibility, I'll aprove this. The new reviewer already ignores that setting. Since we have the Toggle auto advance feature in the reviewer, which is more pratical than going to the settings, removing it shouldn't create a big problem.

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees
No one assigned
Labels
Needs Second Approval Has one approval, one more approval to merge Strings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Automatic Display Answer global setting
3 participants
@MorenoTropical @brishtibheja @BrayanDSO